Collation argument for create managed instance by NMijat1024 · Pull Request #5008 · Azure/azure-sdk-for-net

NMijat1024 · 2018-11-09T20:12:34Z

Description

Azure/azure-rest-api-specs#4314

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda · 2018-11-12T17:29:39Z

@NMijat1024 Please squash your commits into a single commit

dsgouda

Looks good, please squash commits

dsgouda · 2018-11-12T22:25:56Z

@azuresdkci retest this please

NMijat1024 · 2018-11-15T14:35:04Z

@dsgouda Looks better now

NMijat1024 · 2018-11-15T14:35:22Z

@azuresdkci retest this please

dsgouda

@jaredmoo just wondering if you'd like working on the same version in a branch and merging it all together to psSdkJson6. I see these PRs are for the same unpublished version of the SDK

dsgouda · 2018-11-15T15:57:59Z

Was this autogenerated or edited by hand?

Autogenerated.

@fearthecowboy Is such encoding expected in generated code?

What's the problem? It has changed < and > to { and }. The braces don't need to be xml escaped.

dsgouda · 2018-11-15T16:01:08Z

Please update the changes introduced here to the PackageReleaseNotes in csproj

This is also auto generated. Should I revert all the changes that are not tied to my feature?

Please do not revert any files.
Since autogenerating from the latest changes introduces these changes, they must be recorded in the PackageReleaseNotes
Please consult with @jaredmoo regarding this

Weird, did autorest remove this constructor?

@fearthecowboy Here is the PR which used preview version of autorest. #5029

Looks like that deletes the constructor too

So, shall we get this merged? @dsgouda @jaredmoo

I already signed off several days ago, I don't have the ability to merge.

I wanted to make sure this doesn't adversely affect customers. SInce this is preview, it should be OK to merge this

jaredmoo

Please update PackageReleaseNotes in Microsoft.Azure.Management.Sql.csproj

jaredmoo · 2018-11-15T16:35:47Z

What's the problem? It has changed < and > to { and }. The braces don't need to be xml escaped.

jaredmoo · 2018-11-15T16:36:55Z

Weird, did autorest remove this constructor?

Add package release notes

dsgouda · 2018-11-15T17:08:26Z

@jaredmoo not just the constructor but these changes too

It looks like autorest is being weird and shuffling the methods around the file

NMijat1024 · 2018-11-15T17:29:34Z

@jaredmoo @dsgouda Package release notes are updated.

dsgouda

LGTM

dsgouda suggested changes Nov 12, 2018

View reviewed changes

dsgouda added the Changes Requested label Nov 12, 2018

NMijat1024 force-pushed the psSdkJson6 branch from 64cf23b to 9708cb8 Compare November 15, 2018 14:24

dsgouda suggested changes Nov 15, 2018

View reviewed changes

jaredmoo reviewed Nov 15, 2018

View reviewed changes

Collation argument for create managed instance

4de65ce

Add package release notes

dsgouda reviewed Nov 15, 2018

View reviewed changes

NMijat1024 force-pushed the psSdkJson6 branch from 9708cb8 to 4de65ce Compare November 15, 2018 17:28

jaredmoo approved these changes Nov 15, 2018

View reviewed changes

dsgouda approved these changes Nov 19, 2018

View reviewed changes

dsgouda removed the Changes Requested label Nov 19, 2018

dsgouda merged commit 8e0f068 into Azure:psSdkJson6 Nov 19, 2018

NMijat1024 mentioned this pull request Nov 21, 2018

Bump the version to 1.24.0-preview #5043

Merged

9 tasks

Conversation

NMijat1024 commented Nov 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

dsgouda commented Nov 12, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Nov 12, 2018

Uh oh!

NMijat1024 commented Nov 15, 2018

Uh oh!

NMijat1024 commented Nov 15, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredmoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NMijat1024 commented Nov 15, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NMijat1024 commented Nov 9, 2018 •

edited

Loading